Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update monitoring-apis.asciidoc to remove outdated information about api.http.port #15067

Closed
wants to merge 1 commit into from
Closed

Update monitoring-apis.asciidoc to remove outdated information about api.http.port #15067

wants to merge 1 commit into from

Conversation

herrBez
Copy link

@herrBez herrBez commented May 25, 2023

Remove note that no longer applies given that api.http.port is now a range between port 9600 to port 9700

Release notes

What does this PR do?

Remove a misleading note in this documentation page that does not apply anymore what reported in the logstash settings file.

Why is it important/What is the impact to the user?

This issue is important because the documentation contained misleading information that does not apply anymore.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@herrBez
Update monitoring-apis.asciidoc
2df85a6 
Remove note that no longer applies given that api.http.port is now a range between port 9600 to port 9700
@mergify Mergify
Copy link

mergify bot commented Mar 5, 2025

This pull request does not have a backport label. Could you fix it @herrBez? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

@mergify Mergify
Copy link

mergify bot commented Mar 5, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Mar 5, 2025
@mergify Mergify
Copy link

mergify bot commented Mar 5, 2025

This pull request is now in conflicts. Could you fix it @herrBez? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b herrBez-patch-1 upstream/herrBez-patch-1
git merge upstream/main
git push upstream herrBez-patch-1

@herrBez herrBez closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-8.x Automated backport to the 8.x branch with mergify status:needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herrBez @roaksoax